Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: patch namelink regression #106363

Merged
merged 3 commits into from Dec 11, 2020
Merged

cmake: patch namelink regression #106363

merged 3 commits into from Dec 11, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 8, 2020 •
edited

Motivation for this change

see:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ttuegel and LnL7 December 8, 2020 17:10
Jonathan Ringer added 2 commits December 8, 2020 09:32
@jonringer
Revert "aws-checksums: fix build with cmake 3.19"
b173bc8 
This reverts commit 61574a0.

no longer needed after namelink fixes to cmake
@jonringer
Revert "aws-c-common: fix build with cmake 3.19"
336c0f1 
This reverts commit 42c8929.

no longer needed with cmake namelink fixes
@ofborg ofborg bot requested a review from edolstra December 8, 2020 18:20
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build nix

@mweinelt mweinelt added this to WIP in Staging via automation Dec 8, 2020
@mweinelt mweinelt moved this from WIP to Needs review in Staging Dec 8, 2020
@bcdarwin
Copy link
Member

Also fixes gdcm and itk (which vendors gdcm) which were affected similarly to #106329.

@jonringer
Copy link
Contributor Author

it was hinted that 3.19.2 may be released soon, but that doesn't seem to be the case. Merging

@jonringer jonringer merged commit 18c432f into NixOS:staging Dec 11, 2020
Staging automation moved this from Needs review to Done Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@LnL7 LnL7 Awaiting requested review from LnL7

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @bcdarwin