Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform_0_14: 0.14.0 -> 0.14.2 #106372

Merged
merged 1 commit into from Dec 9, 2020
Merged

terraform_0_14: 0.14.0 -> 0.14.2 #106372

merged 1 commit into from Dec 9, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 8, 2020

Motivation for this change

https://github.com/hashicorp/terraform/releases/tag/v0.14.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dbirks
dbirks approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@dbirks dbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, builds nicely for me too on NixOS. The new changelog link looks good too. 👍

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106372 run on x86_64-linux 1

1 package built:
  • terraform_0_14

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106372 run on x86_64-darwin 1

1 package built:
  • terraform_0_14

@marsam marsam changed the title terraform_0_14: 0.14.0 -> 0.14.1 terraform_0_14: 0.14.0 -> 0.14.2 Dec 8, 2020
@ofborg ofborg bot requested a review from babariviere December 8, 2020 21:41
@marsam marsam merged commit dbf381e into NixOS:master Dec 9, 2020
@marsam marsam deleted the update-terraform_0_14 branch December 9, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbirks dbirks dbirks approved these changes

@babariviere babariviere babariviere approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @SuperSandro2000 @dbirks @babariviere