dgen: init at 1.33 #106359
dgen: init at 1.33 #106359
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
| let | ||
| pname = "dgen-sdl"; | ||
| version = "1.33"; | ||
| in stdenv.mkDerivation { | ||
| inherit pname version; |
There was a problem hiding this comment.
| let | |
| pname = "dgen-sdl"; | |
| version = "1.33"; | |
| in stdenv.mkDerivation { | |
| inherit pname version; | |
| in stdenv.mkDerivation rec { | |
| pname = "dgen-sdl"; | |
| version = "1.33"; |
Please stop doing this.
| platforms = with platforms; unix; | ||
| }; | ||
| } | ||
| # TODO: handle configure options |
There was a problem hiding this comment.
What happens with the TODO?
There was a problem hiding this comment.
dgen has some interesting options, as building debuggers and emulating some extra processors.
I don know what is the better approach here: using a config parameter (with many enable subparameters) or directly listing possibilites as enableDebugger, enableCoProcessor etc.
Anyway, at least it runs Sonic!
There was a problem hiding this comment.
directly listing possibilites as enableDebugger, enableCoProcessor etc.
That is what I saw so far for packages. A config parameter is only used for modules.
|
Result of 1 package failed to build:
|
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)