Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardnotes: 3.3.3 -> 3.5.11 #106392

Merged
merged 1 commit into from Dec 9, 2020
Merged

standardnotes: 3.3.3 -> 3.5.11 #106392

merged 1 commit into from Dec 9, 2020

Conversation

tasmo
Copy link
Contributor

@tasmo tasmo commented Dec 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106392 run on x86_64-linux 1

1 package built:
  • standardnotes

@SuperSandro2000 SuperSandro2000 merged commit 92a721a into NixOS:master Dec 9, 2020
@svrana
Copy link
Member

svrana commented Dec 9, 2020

I tried this update on nixos 20.09 and running standardnotes results in:

A JavaScript error occurred in the main process
Uncaught Exception:
Error: libsecret-1.so.0: cannot open shared object file: No such file or directory
at process.func [as dlopen] (electron/js2c/asar.js:140:31)
at Object.Module._extensions..node (internal/modules/cjs/loader.js:1034:18)
at Object.func [as .node] (electron/js2c/asar.js:149:18)
at Module.load (internal/modules/cjs/loader.js:815:32)
at Module._load (internal/modules/cjs/loader.js:727:14)
at Function.Module._load (electron/js2c/asar.js:769:28)
at Module.require (internal/modules/cjs/loader.js:852:19)
at require (internal/modules/cjs/helpers.js:74:18)
at Object. (/nix/store/6vfxldyk57frisblyqs3mba8w8v5qcda-standardnotes-3.5.11-extracted/resources/app.asar/node_modules/keytar/lib/keytar.js:1:14)
at Module._compile (internal/modules/cjs/loader.js:967:30)

I expected to find libsecret added to the libraries 'expected in an appimage install' in master (i.e., pkgs/build-support/appimage/default.nix) that I'm missing in 20.09, but don't see any changes there. I'll keep poking around, but love to get this working on 20.09.

@tasmo
Copy link
Contributor Author

tasmo commented Dec 9, 2020

Now I get the same error! Don't know why it did work before.

@tasmo
Copy link
Contributor Author

tasmo commented Dec 9, 2020

@SuperSandro2000, @M-Gregoire

Result of nixpkgs-review pr 106392 run on x86_64-linux 1
1 package built:

I had to fix the pull request. Tested it again.

@svrana
Copy link
Member

svrana commented Dec 9, 2020

Yes, that resolves the error, thanks @tasmo!

When starting this new version I was told I needed to grant standardnotes access to the system keyring (libsecret) and provided some steps that weren't very helpful without a 'software store' or the 'snap' command, i.e., snap connect standard-notes:password-manager-service. I'll probably just store unencrypted which is also an option as I'm not sure how to give it permission. Doesn't sound like it would be safe to provide that permission by default even if there was a way, but would be curious how to enable that so as not to have passwords in plaintext.

@svrana
Copy link
Member

svrana commented Dec 9, 2020

I found that the message disappeared after enabling gnome-keyring via
services.gnome3.gnome-keyring.enable = true; in configuration.nix.

@evenbrenden
Copy link
Contributor

@tasmo Any reason for not including https://github.com/tasmo/nixpkgs/commit/601784d1ec0665d625812e11bf69a7d5e88da514 in this (or a separate) PR? libsecret dependency is still missing on unstable. Doesn't look like it's about to added to the appimage environment any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants