Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Eclipse IDE for RCP and RAP developer #106358

Merged
merged 1 commit into from Dec 9, 2020
Merged

Added Eclipse IDE for RCP and RAP developer #106358

merged 1 commit into from Dec 9, 2020

Conversation

ngiger
Copy link
Contributor

@ngiger ngiger commented Dec 8, 2020

Motivation for this change

I use the Eclipse IDE for RCP and RAP application, as I am developing a RCP based Eclipse application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ngiger ngiger requested a review from rycee as a code owner December 8, 2020 16:10
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106358 run on x86_64-linux 1

1 package built:
  • eclipses.eclipse-rcp

@rycee rycee merged commit d955d0a into NixOS:master Dec 9, 2020
@rycee
Copy link
Member

rycee commented Dec 9, 2020

Thanks! Merged to master.

@ngiger ngiger deleted the eclipse-rcp branch March 12, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ngiger @SuperSandro2000 @rycee