Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steamPackages.steam-runtime: 0.20200720.0 → 0.20201203.1 #106393

Merged
merged 2 commits into from Dec 9, 2020
Merged

steamPackages.steam-runtime: 0.20200720.0 → 0.20201203.1 #106393

merged 2 commits into from Dec 9, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 8, 2020 •
edited

Motivation for this change

bump the steam-runtime, having issues with crusader kings III

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Dec 8, 2020

Result of nixpkgs-review pr 106393 1

5 packages failed to build:
  • kodiPlugins.steam-launcher
  • lutris
  • steam
  • steam-run
  • steamcmd

@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 106393 run on x86_64-linux 1

5 packages built:
  • kodiPlugins.steam-launcher
  • lutris
  • steam
  • steam-run
  • steamcmd

@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/106393
5 packages built:
kodiPlugins.steam-launcher lutris steam steam-run steamcmd

@jonringer
Copy link
Contributor Author

was able to start csgo

@jonringer jonringer merged commit f3103fe into NixOS:master Dec 9, 2020
@jonringer jonringer deleted the bump-steam-rt branch December 9, 2020 00:33
@srhb
Copy link
Contributor

srhb commented Dec 19, 2020

Should this be backported as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@lovesegfault lovesegfault lovesegfault approved these changes

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @ryantm @lovesegfault @srhb