Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maestral-gui: 1.2.1 -> 1.3.1 #106361

Merged
merged 6 commits into from Dec 11, 2020
Merged

maestral-gui: 1.2.1 -> 1.3.1 #106361

merged 6 commits into from Dec 11, 2020

Conversation

SFrijters
Copy link
Member

Motivation for this change

Upstream update.
Also added some missing requirements.

Note that the 1.3 release was a bit messy according to samschott/maestral#250 (comment), hence the overrides for watchdog and survey. I tried to follow other similar occurrences in python-packages.nix but maybe this is not the way to go?

$ nix-shell -p nixpkgs-review --run "nixpkgs-review rev maestral-1.3"
[...]
6 packages added:
python37Packages.survey (init at 3.1.1) python37Packages.wrapio (init at 0.3.8) python38Packages.survey (init at 3.1.1) python38Packages.wrapio (init at 0.3.8) python39Packages.survey (init at 3.1.1) python39Packages.wrapio (init at 0.3.8)

4 packages updated:
maestral (1.2.1 → 1.3.1) maestral-gui (1.2.1 → 1.3.1) python37Packages.maestral (1.2.1 → 1.3.1) python38Packages.maestral (1.2.1 → 1.3.1)
[...]
9 packages built:
maestral maestral-gui python37Packages.maestral python37Packages.survey python37Packages.wrapio python38Packages.survey python38Packages.wrapio python39Packages.survey python39Packages.wrapio
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from peterhoeg December 8, 2020 16:34
@SFrijters SFrijters mentioned this pull request Dec 8, 2020
Closed
10 tasks
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106361 run on x86_64-linux 1

9 packages built:
  • maestral (python38Packages.maestral)
  • maestral-gui
  • python37Packages.maestral
  • python37Packages.survey
  • python37Packages.wrapio
  • python38Packages.survey
  • python38Packages.wrapio
  • python39Packages.survey
  • python39Packages.wrapio

@SuperSandro2000
Copy link
Member 

python38Packages.wrapio.log                                                                                                                                                                 109:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python39Packages.wrapio.log                                                                                                                                                                 109:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python38Packages.survey.log                                                                                                                                                                 131:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python37Packages.survey.log                                                                                                                                                                 131:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python39Packages.survey.log                                                                                                                                                                 131:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python37Packages.wrapio.log                                                                                                                                                                 109:Ran 0 tests in 0.000s

Please add doCheck = false; and pythonImportsCheck.

@SFrijters
Copy link
Member Author

@SuperSandro2000 Done, rebased the changes into the init commits.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106361 run on x86_64-linux 1

9 packages built:
  • maestral (python38Packages.maestral)
  • maestral-gui
  • python37Packages.maestral
  • python37Packages.survey
  • python37Packages.wrapio
  • python38Packages.survey
  • python38Packages.wrapio
  • python39Packages.survey
  • python39Packages.wrapio

@SuperSandro2000 SuperSandro2000 merged commit 3e96635 into NixOS:master Dec 11, 2020
@SFrijters SFrijters deleted the maestral-1.3 branch December 11, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SFrijters @SuperSandro2000