Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flask-appbuilder: fix flask-babel dep #106369

Merged
merged 1 commit into from Dec 8, 2020
Merged

flask-appbuilder: fix flask-babel dep #106369

merged 1 commit into from Dec 8, 2020

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

Should fix this https://hydra.nixos.org/build/131278146

Things done

Fixed Flask-Babel dependency version condition

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc December 8, 2020 18:14
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 8, 2020 •
edited

Result of nixpkgs-review pr 106369 run on x86_64-darwin 1

1 package failed to build:
  • apache-airflow (python37Packages.apache-airflow)
3 packages built:
  • python37Packages.flask-appbuilder
  • python38Packages.flask-appbuilder
  • python39Packages.flask-appbuilder
Executing pythonRemoveTestsDir
Finished executing pythonRemoveTestsDir
running install tests
ImportError while loading conftest '/private/var/folders/r4/k85s52jx3555ckj0wty615s00000gp/T/nix-build-python3.7-Shapely-1.7.1.drv-0/Shapely-1.7.1/tests/conftest.py'.
tests/__init__.py:4: in <module>
    from shapely.geos import geos_version_string, lgeos, WKTWriter
/nix/store/wrbhvn34s59zb122w1p56c98xa8ylxyi-python3.7-Shapely-1.7.1/lib/python3.7/site-packages/shapely/geos.py:65: in <module>
    free = CDLL('/nix/store/f9bhb6zyyyyxwvfasab78ixkdkc76d38-Libsystem-osx-10.12.6/lib/libc.dylib').free
/nix/store/z1i87c51s6vvx544xh7yqgvfgzcb9hkj-python3-3.7.9/lib/python3.7/ctypes/__init__.py:364: in __init__
    self._handle = _dlopen(self._name, mode)
E   OSError: dlopen(/nix/store/f9bhb6zyyyyxwvfasab78ixkdkc76d38-Libsystem-osx-10.12.6/lib/libc.dylib, 6): image not found
builder for '/nix/store/b8hj7fj4vy8dh866nq0qc00284w2wsg3-python3.7-Shapely-1.7.1.drv' failed with exit code 4
cannot build derivation '/nix/store/rnlwrw2m8drl0zrpljy608jzchbgfr2m-python3.7-flask-admin-1.5.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rvw0ybdkp1b778vrkv95365l3zi1kc8v-python3.7-apache-airflow-1.10.5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/rvw0ybdkp1b778vrkv95365l3zi1kc8v-python3.7-apache-airflow-1.10.5.drv' faile

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106369 run on x86_64-linux 1

4 packages built:
  • apache-airflow (python37Packages.apache-airflow)
  • python37Packages.flask-appbuilder
  • python38Packages.flask-appbuilder
  • python39Packages.flask-appbuilder

jonringer
jonringer approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes build

https://github.com/NixOS/nixpkgs/pull/106369
4 packages built:
apache-airflow python37Packages.flask-appbuilder python38Packages.flask-appbuilder python39Packages.flask-appbuilder

@jonringer jonringer merged commit 4a7bcab into NixOS:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SCOTT-HAMILTON @SuperSandro2000 @jonringer