Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] apparmor: 2.13.5 -> 2.13.6 #106374

Merged
merged 1 commit into from Dec 17, 2020
Merged

[staging] apparmor: 2.13.5 -> 2.13.6 #106374

merged 1 commit into from Dec 17, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Dec 8, 2020

Motivation for this change

Upstream release: https://gitlab.com/apparmor/apparmor/-/wikis/Release_Notes_2.13.6

Meanwhile, there's also a new major release, out: https://gitlab.com/apparmor/apparmor/-/wikis/Release_Notes_3.0
As with any major release, there are some backwards incompatible changes, so the migration might require changes, announcements or maybe just some kind of plan…

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added this to WIP in Staging via automation Dec 8, 2020
@mweinelt mweinelt moved this from WIP to Needs review in Staging Dec 8, 2020
@ju1m
Copy link
Contributor

ju1m commented Dec 14, 2020

FYI, #101071 is bringing AppArmor 3.0 and a more correct and flexible integration of AppArmor into NixOS.

@ajs124
Copy link
Member Author

ajs124 commented Dec 14, 2020

I know, we've already had something like that internally for over a year, just not in an upstreamable state.

@bqv
Copy link
Contributor

bqv commented Dec 15, 2020

we've already had something like that internally for over a year, just not in an upstreamable state.

Internally? Would you be interested in creating an external repository similar to as I've just done in http://github.com/bqv/apparmor-nix?

@FRidh FRidh merged commit e60919c into NixOS:staging Dec 17, 2020
Staging automation moved this from Needs review to Done Dec 17, 2020
@ajs124 ajs124 deleted the upd/apparmor branch December 17, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@joachifm joachifm Awaiting requested review from joachifm

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @ju1m @bqv @FRidh