Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-workspace: fix QtQuick style used by KCMs #106396

Merged
merged 1 commit into from Dec 9, 2020
Merged

plasma-workspace: fix QtQuick style used by KCMs #106396

merged 1 commit into from Dec 9, 2020

Conversation

InternetUnexplorer
Copy link
Contributor

Motivation for this change

This lets the KCMs in plasma-workspace use the style provided by qqc2-desktop-style instead of the default QtQuick one. The KCMs in plasma-desktop already have this.

Before After
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@InternetUnexplorer
plasma-workspace: fix QtQuick style used by KCMs
fbae779 
The KCMs now use the style provided by `qqc2-desktop-style` instead of
the default QtQuick one.
@InternetUnexplorer
Copy link
Contributor Author

This is totally a nitpick, but I just realized that the commit/title should probably say "style" instead of "theme". Whoops.

@InternetUnexplorer InternetUnexplorer changed the title plasma-workspace: fix QtQuick theme used by KCMs plasma-workspace: fix QtQuick style used by KCMs Dec 9, 2020
@ttuegel ttuegel merged commit 5f92d14 into NixOS:master Dec 9, 2020
@ttuegel
Copy link
Member

ttuegel commented Dec 9, 2020

Thanks! 😃

@InternetUnexplorer InternetUnexplorer deleted the fix/plasma-workspace-use-qqc2-style branch December 9, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@InternetUnexplorer @ttuegel @Janik-Haag