Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gerbera: revert fmt to supported version #106387

Closed
wants to merge 1 commit into from
Closed

gerbera: revert fmt to supported version #106387

wants to merge 1 commit into from

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

https://hydra.nixos.org/build/131263502, gerbera doesn't build

Things done

Bisected fmt to find which commit introduced a build failure. (Took a bit of time but hopefully I could reduce the build failure testing build with a restricted payload command : only building the few files concerned). This is the failing commit fmtlib/fmt@a2c4fed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SCOTT-HAMILTON SCOTT-HAMILTON mentioned this pull request Dec 8, 2020
Closed
SuperSandro2000
SuperSandro2000 requested changes Dec 9, 2020
View reviewed changes
pkgs/servers/gerbera/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/fmt/default.nix Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
pkgs/servers/gerbera/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106387 run on x86_64-darwin 1

1 package built:
  • fmt_7_0_1

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106387 run on x86_64-linux 1

2 packages built:
  • fmt_7_0_1
  • gerbera

@SCOTT-HAMILTON SCOTT-HAMILTON mentioned this pull request Dec 9, 2020
Merged
10 tasks
@SCOTT-HAMILTON
Copy link
Contributor Author

Obsolete since #106480. It's the bundled version of fmt in spdlog who's breaking the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@ardumont ardumont Awaiting requested review from ardumont

@jeroendehaas jeroendehaas Awaiting requested review from jeroendehaas

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SCOTT-HAMILTON @SuperSandro2000