Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform_0_11: drop #106373

Merged
merged 1 commit into from Dec 10, 2020
Merged

terraform_0_11: drop #106373

merged 1 commit into from Dec 10, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 8, 2020

Motivation for this change

Terraform 0.11 is being deprecated https://www.hashicorp.com/blog/deprecating-terraform-0-11-support-in-terraform-providers

#105746 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from zimbatm December 8, 2020 19:16
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106373 run on x86_64-linux 1

1 package built:
  • terraform_plugins_test

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106373 run on x86_64-darwin 1

@marsam marsam merged commit cc9c820 into NixOS:master Dec 10, 2020
@marsam marsam deleted the drop-terraform_0_11 branch December 10, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @SuperSandro2000