Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tinc: rfc42 and tests #106073

Merged
merged 2 commits into from Dec 14, 2020
Merged

nixos/tinc: rfc42 and tests #106073

merged 2 commits into from Dec 14, 2020

Conversation

minijackson
Copy link
Member

Motivation for this change

I wanted to have RFC42-style options to be able to reuse these values in other places (the test is an example of that).

Tests also are awesome.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@minijackson
Copy link
Member Author

Pinging @volth @ericsagnes going by git log

pacien
pacien reviewed Dec 6, 2020
View reviewed changes
Copy link
Contributor

@pacien pacien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the handy settings options and the test.
I've added a few suggestions to the proposed changes.
You can perhaps register yourself as a maintainer for the module and the test.

nixos/modules/services/networking/tinc.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tinc.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tinc.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tinc.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tinc.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tinc.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tinc.nix Outdated Show resolved Hide resolved
nixos/tests/tinc/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tinc.nix Outdated Show resolved Hide resolved
@pacien
Copy link
Contributor

pacien commented Dec 6, 2020

@ofborg test tinc

lheckemann
lheckemann approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! One nit.

nixos/modules/services/networking/tinc.nix Outdated Show resolved Hide resolved
@lheckemann lheckemann merged commit c40f060 into NixOS:master Dec 14, 2020
@minijackson minijackson deleted the tinc-rfc42-and-tests branch February 1, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacien pacien pacien approved these changes

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minijackson @pacien @lheckemann