New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/tinc: rfc42 and tests #106073
nixos/tinc: rfc42 and tests #106073
Conversation
Pinging @volth @ericsagnes going by git log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the handy settings
options and the test.
I've added a few suggestions to the proposed changes.
You can perhaps register yourself as a maintainer for the module and the test.
11297e7
to
382a1d3
Compare
@ofborg test tinc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this! One nit.
382a1d3
to
6cd9750
Compare
Motivation for this change
I wanted to have RFC42-style options to be able to reuse these values in other places (the test is an example of that).
Tests also are awesome.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)