ocamlPackages.stdint: 0.6.0 -> 0.7.0 #106072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternenseemann
requested changes
Dec 6, 2020
| @@ -2,15 +2,15 @@ | |||
|
|
|||
| buildDunePackage rec { | |||
| pname = "stdint"; | |||
| version = "0.6.0"; | |||
| version = "0.7.0"; | |||
|
|
|||
| minimumOCamlVersion = "4.07"; | |||
There was a problem hiding this comment.
Introduces support with lower OCaml versions.
Suggested change
| minimumOCamlVersion = "4.07"; | |
| minimumOCamlVersion = "4.03"; |
sternenseemann
requested changes
Jan 21, 2021
There was a problem hiding this comment.
Will make a fixed PR as soon as there's a patch that fixes the failing tests for stdint 0.7.0 at the moment
| @@ -2,15 +2,15 @@ | |||
|
|
|||
| buildDunePackage rec { | |||
| pname = "stdint"; | |||
| version = "0.6.0"; | |||
| version = "0.7.0"; | |||
|
|
|||
| minimumOCamlVersion = "4.07"; | |||
|
|
|||
| src = fetchFromGitHub { | |||
There was a problem hiding this comment.
Should use fetchurl and the release tarball.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ocaml4.10.0-stdint/versions.
meta.description for ocamlPackages.stdint is: "Various signed and unsigned integers for OCaml"
meta.homepage for ocamlPackages.stdint is: "https://github.com/andrenth/ocaml-stdint"
meta.changelog for ocamlPackages.stdint is: ""
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
built on NixOS
Warning: a test defined in
passthru.testsdid not pass0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 0.7.0 with grep in /nix/store/zc0n9fhdj0wl7rbqrpj6bjq9a38bs45j-ocaml4.10.0-stdint-0.7.0
directory tree listing: https://gist.github.com/c2746a931e8295224702860f517399e2
du listing: https://gist.github.com/8eb39db13f2ba36b8cb6eb23bba9abd7
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review14 packages built:
Maintainer pings
cc @gebner for testing.