pytest_xdist: make version conditional on python interpreter #106059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like a number of other modules, the newer version of `pytest_xdist` simply does not work on a python 2.x interpreter, resulting in instantiation errors for tools using the 2.x interpreter like: ``` error: pytest-xdist-2.1.0 not supported for interpreter python2.7 (use '--show-trace' to show detailed location information) ``` This change uses the same strategy as those other modules to conditionalize the version that is selected on the version of the python interpreter. I would like to keep this working for a while, at least, since the DeDRM plugin for Calibre only works under python2 for the moment.
FRidh
approved these changes
Dec 6, 2020
|
#105878 is better because both and are on 2.1.0. |
|
Merged #105878. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix for #106058
Like a number of other modules, the newer version of
pytest_xdistsimply does not work on a python 2.x interpreter, resulting in
instantiation errors for tools using the 2.x interpreter like:
This change uses the same strategy as those other modules to
conditionalize the version that is selected on the version of the
python interpreter.
I would like to keep this working for a while, at least, since the
DeDRM plugin for Calibre only works under python2 for the moment.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)