nixos/prometheus-exporters/py-air-control: init #106067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urbas
commented
Dec 6, 2020
|
|
||
| in | ||
| { | ||
| port = 9896; |
There was a problem hiding this comment.
This port has been added to the Prometheus' port allocations table.
urbas
force-pushed
the
prometheus-exporter-py-air-control
branch
from
66d6aa0
to
8a82e75
Compare
|
Added tests. They will fail until the Edit: the package was updated and the tests now pass. @WilliButz: Is there a way to trigger these new tests in CI? Here's the way I ran them: |
WilliButz
requested changes
Dec 10, 2020
nixos/modules/services/monitoring/prometheus/exporters/py-air-control.nix
Outdated
Show resolved
Hide resolved
urbas
force-pushed
the
prometheus-exporter-py-air-control
branch
2 times, most recently
from
369dcf2
to
2bbf895
Compare
urbas
force-pushed
the
prometheus-exporter-py-air-control
branch
from
2bbf895
to
4948743
Compare
|
@GrahamcOfBorg test prometheus-exporters.py-air-control |
WilliButz
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This change adds the
py-air-controlPrometheus Exporter Module for NixOS.This module sets up the
prometheus-py-air-control-exporterservice which gathers air quality information from an air quality/air purification device connected to the network.This is a follow-up to the PR #105966.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/) (tested the execution of this newprometheus-py-air-control-exporterservice on a Raspberry Pi with an actual air purifier device)nix path-info -Sbefore and after)cc @SuperSandro2000 @lukegb