Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.llfuse: 1.3.6 -> 1.3.8, fix tests #106279

Merged
merged 3 commits into from Dec 8, 2020
Merged

pythonPackages.llfuse: 1.3.6 -> 1.3.8, fix tests #106279

merged 3 commits into from Dec 8, 2020

Conversation

erosennin
Copy link
Contributor

Motivation for this change

Fixes #106266.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bjornfor December 7, 2020 20:35
Flakebi
Flakebi approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tested borg and it works fine.

Result of nixpkgs-review pr 106279 run on x86_64-linux 1

1 package failed to build:
  • s3ql
4 packages built:
  • borgbackup
  • python37Packages.llfuse
  • python38Packages.llfuse
  • python39Packages.llfuse

s3ql was already broken, so not a regression.

@nyanloutre
Copy link
Member

You may need to rebase on master and revert changes from this PR #106270

@erosennin
Copy link
Contributor Author

Thanks, done.

@seppeljordan
Copy link
Contributor

Result of nixpkgs-review pr 106279 run on x86_64-linux 1

1 package failed to build:
  • s3ql
4 packages built:
  • borgbackup
  • python37Packages.llfuse
  • python38Packages.llfuse
  • python39Packages.llfuse

@nyanloutre
Copy link
Member

s3ql is getting fixed here : #106283

This was referenced Dec 8, 2020
Closed
Closed
@siriobalmelli
Copy link
Contributor

LGTM

Result of nixpkgs-review pr 106279 on Darwin:

4 packages built:
borgbackup python37Packages.llfuse python38Packages.llfuse python39Packages.llfuse

jonringer
jonringer approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/106279
1 package failed to build:
s3ql

4 packages built:
borgbackup python37Packages.llfuse python38Packages.llfuse python39Packages.llfuse

@jonringer jonringer merged commit 799e330 into NixOS:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Flakebi approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

borgbackup: fails to build
6 participants
@erosennin @nyanloutre @seppeljordan @siriobalmelli @Flakebi @jonringer