Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: generate deterministic manifest #106284

Merged
merged 1 commit into from Dec 8, 2020
Merged

rustc: generate deterministic manifest #106284

merged 1 commit into from Dec 8, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 7, 2020

The order of the entries in the manifest generated while installing
rustc depends on the (parallel) build, so let's sort it to make it
deterministic. Also remove install.log from the output.

Motivation for this change

Having packages be bit-for-bit reproducible makes it easier to audit
them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: rust label Dec 7, 2020
@ofborg ofborg bot requested review from cstrahan, globin and madjar December 7, 2020 21:41
@raboof @Mic92
rustc: generate deterministic manifest
b909a33 
The order of the entries in the manifest generated while installing
rustc depends on the (parallel) build, so let's sort it to make it
deterministic. Also remove install.log from the output.

Co-Authored-By: Jörg Thalheim <joerg@thalheim.io>
@raboof raboof force-pushed the rustc-deterministic-manifest branch from 9068c46 to b909a33 Compare December 7, 2020 22:02
@raboof raboof changed the base branch from master to staging December 7, 2020 22:03
@Mic92
Copy link
Member

Mic92 commented Dec 8, 2020

Result of nixpkgs-review pr 106284 1

1 package built:
  • fd

@Mic92 Mic92 merged commit 650db4a into NixOS:staging Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@xaverdh xaverdh xaverdh left review comments

@LnL7 LnL7 Awaiting requested review from LnL7

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

@globin globin Awaiting requested review from globin

@madjar madjar Awaiting requested review from madjar

Assignees
No one assigned
Labels
6.topic: reproducible builds 6.topic: rust 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @Mic92 @xaverdh