Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.HTTPTinyCache: init at 0.002 #106291

Merged
merged 3 commits into from Dec 9, 2020
Merged

perlPackages.HTTPTinyCache: init at 0.002 #106291

merged 3 commits into from Dec 9, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Dec 7, 2020

Motivation for this change

Adds the HTTP::Tiny::Cache Perl module

dependencies:
perlPackages.FileUtilTempdir: init at 0.034
perlPackages.Logger: init at 0.037

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

6 packages built:
  • perl530Packages.FileUtilTempdir
  • perl530Packages.HTTPTinyCache
  • perl530Packages.Logger
  • perl532Packages.FileUtilTempdir
  • perl532Packages.HTTPTinyCache
  • perl532Packages.Logger

@zakame
Copy link
Member

zakame commented Dec 8, 2020 •
edited

Result of nixpkgs-review pr 106291 run on other x86_64-linux 1

6 packages built:
  • perl530Packages.FileUtilTempdir
  • perl530Packages.HTTPTinyCache
  • perl530Packages.Logger
  • perl532Packages.FileUtilTempdir
  • perl532Packages.HTTPTinyCache
  • perl532Packages.Logger

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106291 run on x86_64-darwin 1

6 packages built:
  • perl530Packages.FileUtilTempdir
  • perl530Packages.HTTPTinyCache
  • perl530Packages.Logger
  • perl532Packages.FileUtilTempdir
  • perl532Packages.HTTPTinyCache
  • perl532Packages.Logger

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106291 run on x86_64-linux 1

6 packages built:
  • perl530Packages.FileUtilTempdir
  • perl530Packages.HTTPTinyCache
  • perl530Packages.Logger
  • perl532Packages.FileUtilTempdir
  • perl532Packages.HTTPTinyCache
  • perl532Packages.Logger

SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2020
View reviewed changes
pkgs/top-level/perl-packages.nix
Comment on lines +8271 to +8273
version = "0.034";
src = fetchurl {
url = "mirror://cpan/authors/id/P/PE/PERLANCAR/File-Util-Tempdir-0.034.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.034";
src = fetchurl {
url = "mirror://cpan/authors/id/P/PE/PERLANCAR/File-Util-Tempdir-0.034.tar.gz";
version = "0.034";
src = fetchurl rec {
url = "mirror://cpan/authors/id/P/PE/PERLANCAR/File-Util-Tempdir-${version}.tar.gz";

SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2020
View reviewed changes
pkgs/top-level/perl-packages.nix
Comment on lines +9903 to +9907
HTTPTinyCache = buildPerlPackage {
pname = "HTTP-Tiny-Cache";
version = "0.002";
src = fetchurl {
url = "mirror://cpan/authors/id/P/PE/PERLANCAR/HTTP-Tiny-Cache-0.002.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HTTPTinyCache = buildPerlPackage {
pname = "HTTP-Tiny-Cache";
version = "0.002";
src = fetchurl {
url = "mirror://cpan/authors/id/P/PE/PERLANCAR/HTTP-Tiny-Cache-0.002.tar.gz";
HTTPTinyCache = buildPerlPackage red {
pname = "HTTP-Tiny-Cache";
version = "0.002";
src = fetchurl {
url = "mirror://cpan/authors/id/P/PE/PERLANCAR/HTTP-Tiny-Cache-${version}.tar.gz";

SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2020
View reviewed changes
pkgs/top-level/perl-packages.nix
Comment on lines +11566 to +11570
Logger = buildPerlPackage {
pname = "Log-ger";
version = "0.037";
src = fetchurl {
url = "mirror://cpan/authors/id/P/PE/PERLANCAR/Log-ger-0.037.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Logger = buildPerlPackage {
pname = "Log-ger";
version = "0.037";
src = fetchurl {
url = "mirror://cpan/authors/id/P/PE/PERLANCAR/Log-ger-0.037.tar.gz";
Logger = buildPerlPackage rec {
pname = "Log-ger";
version = "0.037";
src = fetchurl {
url = "mirror://cpan/authors/id/P/PE/PERLANCAR/Log-ger-${version}.tar.gz";

@stigtsp
Copy link
Member Author

stigtsp commented Dec 9, 2020 •
edited

@SuperSandro2000 Thanks for the reviews!

However, I'd like to avoid adding ${version} to url: It means making automatic updating having to handle variable interpolation, or more likely adding hacky special cases to parsing, something which I'd like to avoid if possible. (It's also a pattern only used by only 10 derivations i perl-packages.nix)

PS: I've started working on a new update script after volth left and the cpan2nix tool disappeared nix-update-perl-packages. It's still in early phase, but thinking to model after update-python-libraries.py. Contributions welcome.

@stigtsp stigtsp merged commit 2f26107 into NixOS:master Dec 9, 2020
@divi255
Copy link
Contributor

divi255 commented Dec 14, 2020

Good day,

you can get cpan2nix at https://gitee.com/volth/cpan2nix/

volth has a problem with his github account at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stigtsp @zakame @SuperSandro2000 @divi255