Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netbeans: 12.1 -> 12.2 #106300

Merged
merged 2 commits into from Dec 8, 2020
Merged

netbeans: 12.1 -> 12.2 #106300

merged 2 commits into from Dec 8, 2020

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Dec 8, 2020 •
edited

Motivation for this change

Update to next minor release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asbachb asbachb changed the title Update/netbeans netbeans: 12.1 -> 12.1 Dec 8, 2020
@asbachb
Copy link
Contributor Author

asbachb commented Dec 8, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 8, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg bot requested review from rszibele and svanderburg December 8, 2020 00:19
@asbachb asbachb changed the title netbeans: 12.1 -> 12.1 netbeans: 12.1 -> 12.2 Dec 8, 2020
bennyandresen
bennyandresen approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@bennyandresen bennyandresen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Builds under Sandbox and I was able to launch it.

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau December 8, 2020 09:53
timokau
timokau approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timokau timokau merged commit 39ad6d5 into NixOS:master Dec 8, 2020
@asbachb asbachb deleted the update/netbeans branch January 25, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@bennyandresen bennyandresen bennyandresen approved these changes

@rszibele rszibele Awaiting requested review from rszibele

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asbachb @bennyandresen @timokau