Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unbound: Add AF_NETLINK to allowed address families. #106308

Merged
merged 1 commit into from Dec 8, 2020
Merged

unbound: Add AF_NETLINK to allowed address families. #106308

merged 1 commit into from Dec 8, 2020

Conversation

pmeiyu
Copy link
Member

@pmeiyu pmeiyu commented Dec 8, 2020 •
edited

Unbound throws the following error:

--8<---------------cut here---------------start------------->8---
error: failed to list interfaces: getifaddrs: Address family not supported by protocol
fatal error: could not open ports
--8<---------------cut here---------------end--------------->8---

The solution is pulled from upstream:
NLnetLabs/unbound#351

Motivation for this change

Emergent bug fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pmeiyu pmeiyu force-pushed the master branch 2 times, most recently from 72a8037 to eba9573 Compare December 8, 2020 01:46
@pmeiyu
Copy link
Member Author

pmeiyu commented Dec 8, 2020

CC @andir

unbound: Add AF_NETLINK to allowed address families.
3cd1a67 
Unbound throws the following error:

--8<---------------cut here---------------start------------->8---
error: failed to list interfaces: getifaddrs: Address family not supported by protocol
fatal error: could not open ports
--8<---------------cut here---------------end--------------->8---

The solution is pulled from upstream:
NLnetLabs/unbound#351
@flokli
Copy link
Contributor

flokli commented Dec 8, 2020

I ran into this by myself, and confirmed this PR fixes it. Thanks!

Also verified nixosTests.unbound works after this PR, and didn't before. Any idea how we didn't run into this before? 🤷

@flokli flokli merged commit 2535c42 into NixOS:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmeiyu @flokli