Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nix-prefetch-github: 4.0.2 -> 4.0.3 #106289

Merged
merged 1 commit into from Dec 8, 2020
Merged

pythonPackages.nix-prefetch-github: 4.0.2 -> 4.0.3 #106289

merged 1 commit into from Dec 8, 2020

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Dec 7, 2020 •
edited

Motivation for this change

nix-prefetch-github got an update upstream. This is addressed by this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@seppeljordan
Copy link
Contributor Author

Result of nixpkgs-review pr 106289 run on x86_64-linux 1

4 packages built:
  • nix-prefetch-github (python38Packages.nix-prefetch-github)
  • pypi2nix
  • python37Packages.nix-prefetch-github
  • python39Packages.nix-prefetch-github

@srhb
Copy link
Contributor

srhb commented Dec 8, 2020

And this fixes the build on master 👍

jonringer
jonringer approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 106289 1

4 packages built:
  • nix-prefetch-github (python38Packages.nix-prefetch-github)
  • pypi2nix
  • python37Packages.nix-prefetch-github
  • python39Packages.nix-prefetch-github

@jonringer jonringer merged commit 1c6b12d into NixOS:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seppeljordan @srhb @jonringer