Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.poetry: Apply patch to fix failing tests #106292

Merged
merged 1 commit into from Dec 8, 2020
Merged

pythonPackages.poetry: Apply patch to fix failing tests #106292

merged 1 commit into from Dec 8, 2020

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Dec 7, 2020 •
edited

Motivation for this change

The poetry package does not build currently since it is incompatible with our current version of pytest-mock. This incompatibility is addressed upstream in python-poetry/poetry#3457

To fix the issue temporarily in nixpkgs I applied the patch from this PR to the current version in nixpkgs an left a comment with regards to the purpose of the patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@seppeljordan
Copy link
Contributor Author

Result of nixpkgs-review pr 106292 run on x86_64-linux 1

6 packages failed to build:
  • archivy
  • lexicon
  • python37Packages.hypothesis-auto
  • python37Packages.labelbox
  • python38Packages.hypothesis-auto
  • python38Packages.labelbox
28 packages built:
  • ansible-lint (python38Packages.ansible-lint)
  • cmake-language-server
  • pinnwand
  • python37Packages.ansible-lint
  • python37Packages.aria2p
  • python37Packages.backoff
  • python37Packages.goobook
  • python37Packages.myfitnesspal
  • python37Packages.perfplot
  • python37Packages.poetry
  • python37Packages.pyairvisual
  • python37Packages.pysnow
  • python37Packages.rich
  • python37Packages.tinydb
  • python37Packages.wled
  • python37Packages.xdg
  • python38Packages.aria2p
  • python38Packages.backoff
  • python38Packages.goobook
  • python38Packages.myfitnesspal
  • python38Packages.perfplot
  • python38Packages.poetry
  • python38Packages.pyairvisual
  • python38Packages.pysnow
  • python38Packages.rich
  • python38Packages.tinydb
  • python38Packages.wled
  • python38Packages.xdg

@ofborg ofborg bot requested a review from jbaum98 December 7, 2020 22:39
@FRidh
Copy link
Member

FRidh commented Dec 8, 2020

@GrahamcOfBorg build python3.pkgs.poetry

@FRidh FRidh merged commit 908896c into NixOS:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@jbaum98 jbaum98 Awaiting requested review from jbaum98

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seppeljordan @FRidh