Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ungoogled-chromium: 86.0.4240.183-1 -> 87.0.4280.88-1 #106294

Merged
merged 1 commit into from Dec 9, 2020
Merged

ungoogled-chromium: 86.0.4240.183-1 -> 87.0.4280.88-1 #106294

merged 1 commit into from Dec 9, 2020

Conversation

squalus
Copy link
Member

@squalus squalus commented Dec 7, 2020

This updates ungoogled-chromium. This change was created by manually copying the regular chromium expressions and applying a small diff to support the ungoogled patchset.

Performed a cursory test and everything looks good.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @danielfullmer

ungoogled-chromium: 86.0.4240.183-1 -> 87.0.4280.88-1
1416482 
based on chromium master@68d1006c
danielfullmer
danielfullmer approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@danielfullmer danielfullmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and briefly tested working on x86_64-linux.

@squalus
Copy link
Member Author

squalus commented Dec 8, 2020

@primeos

@primeos
Copy link
Member

primeos commented Dec 9, 2020

Thanks!

@primeos primeos merged commit b8936e5 into NixOS:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfullmer danielfullmer danielfullmer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@squalus @primeos @danielfullmer