Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "peak to peak" filter to "amplitude" to reflect that it returns the cycle-by-cycle amplitude, not global. #383

Closed
azonenberg opened this issue Dec 13, 2020 · 1 comment
Labels
filter Filter graph blocks
Milestone

Comments

@azonenberg
Copy link
Collaborator

Also create a new peak to peak filter that returns the global peak to peak of the entire waveform.

@azonenberg azonenberg added the filter Filter graph blocks label Dec 13, 2020
@azonenberg azonenberg added this to the v0.1 milestone May 1, 2021
@azonenberg
Copy link
Collaborator Author

Closing as wontfix now that we have both outputs as different streams from the same filter

@azonenberg azonenberg closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filter Filter graph blocks
Projects
None yet
Development

No branches or pull requests

1 participant