Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adoptopenjdk-bin, zulu8, zulu, graalvm8-ce, graalvm11-ce: remove demo, sample, and broken man pages #106806

Closed
wants to merge 1 commit into from
Closed

adoptopenjdk-bin, zulu8, zulu, graalvm8-ce, graalvm11-ce: remove demo, sample, and broken man pages #106806

wants to merge 1 commit into from

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Dec 13, 2020

Motivation for this change

See: #106716.

Note that AdoptOpenJDK doesn't have demo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@taku0 taku0 mentioned this pull request Dec 13, 2020
Open
13 tasks
@ofborg ofborg bot requested review from fpletz and hlolli December 13, 2020 07:54
@FRidh FRidh added this to WIP in Staging via automation Dec 17, 2020
@taku0
adoptopenjdk-bin, zulu8, zulu, graalvm8-ce, graalvm11-ce: remove demo…
29cb3eb 
…, sample, and broken man pages

See: NixOS#106716.

Note that AdoptOpenJDK doesn't have demo.
@taku0 taku0 force-pushed the remove_unused_files_from_zulu branch from 7b45500 to 29cb3eb Compare May 4, 2021 05:59
@taku0
Copy link
Contributor Author

taku0 commented May 4, 2021

/rebase-staging

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Failed to rebase

@taku0 taku0 closed this May 4, 2021
Staging automation moved this from WIP to Done May 4, 2021
@taku0 taku0 mentioned this pull request May 4, 2021
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@hlolli hlolli Awaiting requested review from hlolli

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@taku0