buildDunePackage: use dune install instead of opaline #106150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternenseemann
force-pushed
the
dune-test
branch
from
93d32f2
to
f7e1ba1
Compare
10 tasks
|
The JSoO stuff should go away once #106343 is merged. Also, I don’t think that merging into staging first makes much sense, as hydra does not build so many OCaml packages. |
|
Alright! I'll rebase the js_of_ocaml PR as soon as the janeStreet stuff has been merged and then we can progress to this PR and so on. |
sternenseemann
force-pushed
the
dune-test
branch
from
f7e1ba1
to
0d15e64
Compare
|
Rebased against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
By using
dune installoveropaline, we makedune(and of courseocamlandfindlib) the sole "static" dependency of any dune package and thus get rid of circular dependency (or bootstrapping) issues because ofopaline. More specifically: currently we need to buildopalineand all its dependenciesopam-file-formatwithoutdune. Also we can't enable tests foropam-file-formatsincealcotestis built usingbuildDunePackage. This would be no issue if we use dune's install implementation.I've tested this change using
nixpkgs-reviewso far and it doesn't break anything new in the standardocamlPackagesset.I'm wondering whether this should be PR'd against
stagingrather thanmastersince it changes around 600 ocamlPackages which all exist in multiple versions.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)