Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry to parts of the import script which were failing from time to time #249

Merged
merged 2 commits into from Dec 7, 2020
Merged

Add retry to parts of the import script which were failing from time to time #249

merged 2 commits into from Dec 7, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Dec 7, 2020

fixes #243

@garbas garbas requested a review from ncfavier December 7, 2020 09:35
@garbas
Copy link
Member Author

garbas commented Dec 7, 2020

I think this should make the import script more robust.

ncfavier
ncfavier approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although it would be nice to know exactly why the command is failing. I'll try and reproduce the issue locally with a standard error log.

import-scripts/import_scripts/channel.py Outdated Show resolved Hide resolved
@garbas
Copy link
Member Author

garbas commented Dec 7, 2020

Looks good, although it would be nice to know exactly why the command is failing. I'll try and reproduce the issue locally with a standard error log.

The problem is intermittent, I couldn't reproduce it even once locally.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2020

🚀 Deployed on https://5fcdfbf8f7ef2c151310865f--nixos-search.netlify.app

@ncfavier
Copy link
Member

ncfavier commented Dec 7, 2020

The problem is intermittent, I couldn't reproduce it even once locally.

OK

@garbas garbas merged commit 06f5aa9 into master Dec 7, 2020
@garbas garbas deleted the add-retry-to-parts-that-fail-from-time-to-time branch December 7, 2020 09:56
@garbas garbas mentioned this pull request Dec 7, 2020
Closed
@ryantm
Copy link
Member

ryantm commented Dec 7, 2020

I currently see no search results for 20.09 or unstable options.

@garbas
Copy link
Member Author

garbas commented Dec 8, 2020 •
edited

@ryantm I hoped simply adding a retry would solve this, but it looks like we need to either revert #239 or properly implement it. And it wouldn't hurt to make the import script more robust.

I fixed both channels manually and the rest I'll fix today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncfavier ncfavier ncfavier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Options search doesn't work for 20.09
3 participants
@garbas @ncfavier @ryantm