Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPMIView: update src hash #106164

Closed
wants to merge 1 commit into from
Closed

IPMIView: update src hash #106164

wants to merge 1 commit into from

Conversation

iamdenchik
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Please format the title and commit message like IPMIView:: update src hash.

@iamdenchik iamdenchik changed the title IPMIView update sha IPMIView: update sha Dec 7, 2020
@iamdenchik iamdenchik changed the title IPMIView: update sha IPMIView:: update src hash Dec 7, 2020
@iamdenchik iamdenchik changed the title IPMIView:: update src hash IPMIView: update src hash Dec 7, 2020
@iamdenchik
Copy link
Contributor Author

Please format the title and commit message like IPMIView:: update src hash.

done

@ofborg ofborg bot requested a review from vlaci December 7, 2020 11:31
@vlaci
Copy link
Contributor

vlaci commented Dec 7, 2020 •
edited

Hmm, that has does not work for me either:

trying https://www.supermicro.com/wftp/utility/IPMIView/Linux/IPMIView_2.17.0_build.200505_bundleJRE_Linux_x64.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   152  100   152    0     0    234      0 --:--:-- --:--:-- --:--:--   234
100  189k    0  189k    0     0   237k      0 --:--:-- --:--:-- --:--:--  237k
hash mismatch in fixed-output derivation '/nix/store/dcibg5lhw552197ckzh3iky61fkjxv9z-IPMIView_2.17.0_build.200505_bundleJRE_Linux_x64.tar.gz':
  wanted: sha256:1k2cjpq73j2d4vnjj7q9b38pbccjmls1qp1zy2vb1iv2yh2d76z6
  got:    sha256:1r0zmk9navx6sivgpxslghq75qpsav9llqc5ckhbrc10n5zakcph
cannot build derivation '/nix/store/q7hqvl4rczwip4f0z8chyc7gqjh7xfkv-IPMIView-2.17.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/q7hqvl4rczwip4f0z8chyc7gqjh7xfkv-IPMIView-2.17.0.drv' failed

This URL redirects me to the supermicro home page.

@vlaci
Copy link
Contributor

vlaci commented Dec 7, 2020

Looks like we need to update to 2.18 which can be downloaded from https://www.supermicro.com/wftp/utility/IPMIView/Linux/IPMIView_2.18.0_build.201007_bundleJRE_Linux_x64.tar.gz

@vlaci
Copy link
Contributor

vlaci commented Dec 7, 2020 •
edited

Unfortunately patchelf fails on libiKVM_v11_64.so:

patchelf --set-rpath /nix/store/7in2alrzhkpcax5fk4823ismvsmdk1aj-gcc-9.3.0-lib/lib ./libiKVM_v11_64.so
patchelf: no section headers. The input file is probably a statically linked, self-decompressing binary

patching is still necessary:

ldd libiKVM_v11_64.so
	linux-vdso.so.1 (0x00007ffc3bdfb000)
	libstdc++.so.6 => not found
	libm.so.6 => /nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libm.so.6 (0x00007f243859e000)
	libgcc_s.so.1 => /nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libgcc_s.so.1 (0x00007f2438584000)
	libc.so.6 => /nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libc.so.6 (0x00007f24383c5000)
	/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib64/ld-linux-x86-64.so.2 (0x00007f243d004000)

vlaci
vlaci suggested changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@vlaci vlaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

index 4b740a943c0..370b58709b0 100644
--- a/pkgs/applications/misc/ipmiview/default.nix
+++ b/pkgs/applications/misc/ipmiview/default.nix
@@ -13,12 +13,12 @@
 
 stdenv.mkDerivation rec {
   pname = "IPMIView";
-  version = "2.17.0";
-  buildVersion = "200505";
+  version = "2.18.0";
+  buildVersion = "201007";
 
   src = fetchurl {
     url = "https://www.supermicro.com/wftp/utility/IPMIView/Linux/IPMIView_${version}_build.${buildVersion}_bundleJRE_Linux_x64.tar.gz";
-    sha256 = "1k2cjpq73j2d4vnjj7q9b38pbccjmls1qp1zy2vb1iv2yh2d76z6";
+    sha256 = "10cv63yhh81gjxahsg4y3zp4mjivc217m4z1vcpwvvnds46c65h8";
   };

The above diff fixes the download issue for me. Unfortunately patchelf failse. May need another approach like presetting LD_LIBRARY_PATH

@iamdenchik
Copy link
Contributor Author 

index 4b740a943c0..370b58709b0 100644
--- a/pkgs/applications/misc/ipmiview/default.nix
+++ b/pkgs/applications/misc/ipmiview/default.nix
@@ -13,12 +13,12 @@
 
 stdenv.mkDerivation rec {
   pname = "IPMIView";
-  version = "2.17.0";
-  buildVersion = "200505";
+  version = "2.18.0";
+  buildVersion = "201007";
 
   src = fetchurl {
     url = "https://www.supermicro.com/wftp/utility/IPMIView/Linux/IPMIView_${version}_build.${buildVersion}_bundleJRE_Linux_x64.tar.gz";
-    sha256 = "1k2cjpq73j2d4vnjj7q9b38pbccjmls1qp1zy2vb1iv2yh2d76z6";
+    sha256 = "10cv63yhh81gjxahsg4y3zp4mjivc217m4z1vcpwvvnds46c65h8";
   };

The above diff fixes the download issue for me. Unfortunately patchelf failse. May need another approach like presetting LD_LIBRARY_PATH

me close this task and open for update to the version 2.18.0 ?

@vlaci
Copy link
Contributor

vlaci commented Dec 9, 2020

I am fine with either adjusting this PR or opening up a new one.

@iamdenchik
Copy link
Contributor Author

I am fine with either adjusting this PR or opening up a new one.

#106428

@vlaci
Copy link
Contributor

vlaci commented Dec 9, 2020

Superseeded by #106428

@vlaci vlaci closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlaci vlaci vlaci requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iamdenchik @SuperSandro2000 @vlaci @Janik-Haag