Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archi: unbreak build #106814

Merged
merged 1 commit into from Jan 20, 2021
Merged

archi: unbreak build #106814

merged 1 commit into from Jan 20, 2021

Conversation

freezeboy
Copy link
Contributor

Additionally make a wrapper to put the jdk in the PATH to avoid
needed a global JDK

Motivation for this change

Unbreak Archi build and add a wrapper to put jdk in the PATH

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
archi: unbreak build
b25ba4a 
Additionally make a wrapper to put the jdk in the PATH to avoid
needed a global JDK
@earldouglas
Copy link
Member

Thanks!

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106814 run on x86_64-linux 1

1 package built:
  • archi

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106814 run on x86_64-darwin 1

1 package built:
  • archi

@aanderse
Copy link
Member

This seems solid. Any reason not to merge?

@SuperSandro2000
Copy link
Member

@ofborg eval

@ofborg ofborg bot requested a review from earldouglas January 20, 2021 13:05
@SuperSandro2000 SuperSandro2000 merged commit 9a3761b into NixOS:master Jan 20, 2021
@freezeboy freezeboy deleted the unbreak-archi branch January 22, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earldouglas earldouglas earldouglas approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @earldouglas @SuperSandro2000 @aanderse