ledger-live-desktop: fix missing gschema settings #106711
Conversation
Similar issue to NixOS#89089
|
@TheAncientGoat this actually fixed it for me. |
If I'm not mistaken, that's what the wrapGAppsHook essentially does according to the discussion here #89089 (comment) (and my fix worked - at least for me) Not sure if the one approach is better than the other, but as there hasn't been any activity on the issue #106733 - not sure if I can push this one over the line |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Still relevant |
stale
bot
removed
the
2.status: stale
|
@TheAncientGoat any reason why we can't take this PR out of draft so we can merge it? AFAIK the approach in this PR of using |
|
@andresilva - no reason on my end besides not being able to find reviewers; will take it out of draft if you're happy with it, thanks |
There was a problem hiding this comment.
Sorry, I only actually looked at the patch now. I'm not sure how this is supposed to be working, you have just defined a variable extraPkgs which isn't used anywhere. I think wrapGAppsHook cannot be used by the app image builder since it needs to be defined as a native build input. So I suggest you update the PR to instead do the same as here as suggested by @asymmetric.
|
I'll have a look - not currently using the package because my ledger wasn't being detected anyhow; will give it another go |
|
The ledger not being detected was fixed recently. Make sure you update nixpkgs before trying again. |
|
Hmm, just tested it out while using Gnome - file manager seems to work as expected, don't know if it's a KDE only thing. As I'm using Gnome at the moment I don't have the time to change desktops and triage - if no one else is experiencing the issue I guess we can close? |
|
I am using i3 and also could not replicate the issue. I used to have the |
Similar issue to #89089
Motivation for this change
This package crashes on systems without gtk dependencies otherwise, with a
(ledger-live-desktop:12516): GLib-GIO-ERROR **: 14:14:57.402: No GSettings schemas are installed on the systemerror otherwiseThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)