Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nix-serve: don't run as nogroup #106721

Merged
merged 1 commit into from Jul 18, 2021
Merged

nixos/nix-serve: don't run as nogroup #106721

merged 1 commit into from Jul 18, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 12, 2020 •
edited

nogroup is insecure if shared

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jan 2, 2021

@GrahamcOfBorg test nix-serve

@Mic92
nixos/nix-serve: don't run as nogroup
ac7b872 
nogroup is insecure if shared
@Mic92
Copy link
Member Author

Mic92 commented Jul 18, 2021

@GrahamcOfBorg test nix-serve

@Mic92 Mic92 merged commit 0839cf1 into NixOS:master Jul 18, 2021
@Mic92 Mic92 deleted the nix-serve branch July 18, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @SuperSandro2000