Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] _1password-gui -> 0.8.4 -> 0.9.7 #106722

Merged
merged 16 commits into from Dec 14, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Fixes #106684. However, also requires that we add Electron 11 to release 20.09. @NixOS/nixos-release-managers: is this acceptable?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk and others added 16 commits December 12, 2020 09:20
(cherry picked from commit 1afa7b7)
(cherry picked from commit 0f03d8f)
(cherry picked from commit 48ca228)
make electron point to electron_11

(cherry picked from commit 8cde963)
(cherry picked from commit 1b14ab8)
(cherry picked from commit 934f621)
@danieldk
Copy link
Contributor Author

cc @prusnak as one of the Electron maintainers.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/406

@Lassulus
Copy link
Member

Result of nixpkgs-review pr 106722 1

3 packages built:
  • _1password-gui
  • electron (electron_11)
  • nix-tour

@Lassulus Lassulus merged commit 798e64c into NixOS:release-20.09 Dec 14, 2020
@danieldk danieldk deleted the backport-20.09-1password-0.9.7 branch December 14, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants