Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 1.17.73 -> 1.18.70 #106718

Merged
merged 1 commit into from Dec 17, 2020
Merged

brave: 1.17.73 -> 1.18.70 #106718

merged 1 commit into from Dec 17, 2020

Conversation

buckley310
Copy link
Contributor

Motivation for this change

Web browsers must be kept up-to-date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from rht and uskudnik December 12, 2020 07:20
bbjubjub2494
bbjubjub2494 approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. builds and starts w/o library issues

image

@buckley310 buckley310 mentioned this pull request Dec 17, 2020
Closed
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/298

@danieldk danieldk merged commit 2412278 into NixOS:master Dec 17, 2020
@danieldk
Copy link
Contributor

danieldk commented Dec 17, 2020 •
edited

This update also contains security fixes. Could you backport this to 20.09?

https://nixos.org/manual/nixpkgs/stable/#submitting-changes-stable-release-branches

@buckley310 buckley310 mentioned this pull request Dec 17, 2020
Closed
10 tasks
@buckley310
Copy link
Contributor Author

@danieldk 👍 #107087

@buckley310 buckley310 mentioned this pull request Dec 24, 2020
Merged
10 tasks
@dotlambda dotlambda mentioned this pull request Jan 23, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbjubjub2494 bbjubjub2494 bbjubjub2494 approved these changes

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@buckley310 @nixos-discourse @danieldk @bbjubjub2494