Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.thinc: 7.4.4 -> 7.4.5 #106730

Merged
merged 2 commits into from Dec 14, 2020
Merged

python3Packages.thinc: 7.4.4 -> 7.4.5 #106730

merged 2 commits into from Dec 14, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

python3Packages.thinc: 7.4.4 -> 7.4.5

Changelog:

https://github.com/explosion/thinc/releases/tag/v7.4.5

Also move cython from propagatedBuildInputs to buildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from aptlin and aborsu December 12, 2020 10:36
drewrisinger
drewrisinger suggested changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits Should probably be squashed
  • Builds via nix-review on x86-64:
https://github.com/NixOS/nixpkgs/pull/106730
9 packages built:
python37Packages.spacy python37Packages.textacy python37Packages.thinc python38Packages.spacy python38Packages.textacy python38Packages.thinc python39Packages.spacy python39Packages.textacy python39Packages.thinc

@danieldk
Copy link
Contributor Author 

* [ ]  Commits Should probably be squashed

I don't think commits should be squashed. Having formatting changes and a version bump in the same commit makes diff-ing hard.

(Also, I have seen other PRs rejected because people do formatting changes and a version bump in one commit ;) .)

@marsam marsam merged commit 1b87f82 into NixOS:master Dec 14, 2020
@drewrisinger
Copy link
Contributor

ack @danieldk. I've had it both ways when submitting PRs, depending on the reviewer. I generally lean slightly towards squashing just b/c the mass amount of commits that nixpkgs already has (i.e. slowing down fresh clones), but no real preference.

@danieldk
Copy link
Contributor Author

ack @danieldk. I've had it both ways when submitting PRs, depending on the reviewer. I generally lean slightly towards squashing just b/c the mass amount of commits that nixpkgs already has (i.e. slowing down fresh clones), but no real preference.

Yeah, there doesn't seem to be general agreement on such things.

Thanks for the review!

@danieldk danieldk deleted the thinc-7.4.5 branch December 14, 2020 13:45
@drewrisinger
Copy link
Contributor

Yeah, there doesn't seem to be general agreement on such things.

This suggests it might be worth adding a section to the CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@aptlin aptlin Awaiting requested review from aptlin

@aborsu aborsu Awaiting requested review from aborsu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @drewrisinger @marsam