Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iannix: 0.9.20-b -> unstable-2020-12-09 #106729

Merged
merged 1 commit into from Jan 16, 2021
Merged

iannix: 0.9.20-b -> unstable-2020-12-09 #106729

merged 1 commit into from Jan 16, 2021

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Dec 12, 2020 •
edited

It includes a few bug fixes.
This also allows to migrate to Qt5.15

Motivation for this change

Let the package use Qt5.15 and includes a few unreleased bug fixes

Related to #104474

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
iannix: 0.9.20-b -> unstable-2020-12-09
ed99a16 
It includes a few bug fixes.
This also allows to migrate to Qt5.15
@WolfangAukang
Copy link
Contributor

WolfangAukang commented Jan 16, 2021 •
edited

Result of nixpkgs-review pr 106729 run on x86_64-linux 1

1 package built:
  • iannix

Application working fine for me and code LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/331

@AndersonTorres AndersonTorres merged commit d20d283 into NixOS:master Jan 16, 2021
@freezeboy freezeboy deleted the update-iannix branch January 18, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WolfangAukang WolfangAukang WolfangAukang approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @WolfangAukang @nixos-discourse @AndersonTorres