Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tinc: add reload command #106715

Merged
merged 2 commits into from Dec 12, 2020
Merged

nixos/tinc: add reload command #106715

merged 2 commits into from Dec 12, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 12, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from Lassulus December 12, 2020 06:38
@Lassulus
Copy link
Member

In classic tinc I think this was possible with kill SIGUSR1, do we want to support that also?
Otherwise this looks fine.

@Mic92
Copy link
Member Author

Mic92 commented Dec 12, 2020 •
edited

I already thought about just dropping tinc classic:

  • it does not has a maintainer
  • we no longer use it in the module by default
  • I don't test it, while I test tinc-pre on many hosts

@Lassulus
Copy link
Member

Ah, that sounds also fine, so this LGTM

@Mic92 Mic92 merged commit 5f0d38f into NixOS:master Dec 12, 2020
@Mic92 Mic92 deleted the tinc branch December 12, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @Lassulus