Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp4v2: 4.1.3 -> 4.1.5 #106719

Closed
wants to merge 1 commit into from
Closed

mp4v2: 4.1.3 -> 4.1.5 #106719

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 12, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Dec 12, 2020

Thank you for this work.

Indeed a couple of minor releases quite recently, and I was not subbed to notifications.

There is some reports with dependency compilation/use trouble about 4.1.{4,5}: TechSmith/mp4v2#47

So let us check a couple of those.

@Anton-Latukha
Copy link
Contributor

@GrahamcOfBorg build mixxx

@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Dec 12, 2020

Packages have trouble finding dev files (ERROR:root:Unmet dependency: Could not find libmp4, libmp4v2 or the libmp4v2 development headers..

Since you are at it - please, try to add split outputs to the package:

outputs = [ "bin" "dev" "out" "doc" ];

and see what sticks(populates).

At least from https://packages.debian.org/stretch/amd64/libmp4v2-dev/download it seems that dev output is there.

@Anton-Latukha
Copy link
Contributor

Or we can merge as is, and I would attend further.

@marsam
Copy link
Contributor Author

marsam commented Dec 12, 2020

try to add split outputs to the package:

Sure, I added outputs = [ "out" "dev" "lib" ]; because doc doesn't seem to work

@GrahamcOfBorg build faac

@marsam
Copy link
Contributor Author

marsam commented Dec 14, 2020

@GrahamcOfBorg build mixxx

@Anton-Latukha
Copy link
Contributor

Now we fixed the build error in mixxx, and so now it falls under unresolved dependencies - which is mixxx package config territory.

@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Dec 15, 2020

I consider these improvements as ready for a merge.

@Anton-Latukha
Copy link
Contributor

@GrahamcOfBorg build mp4v2

@marsam
Copy link
Contributor Author

marsam commented Jan 6, 2021

Looking at this again, it breaks cmus and mixxx. Closing this PR for now, sorry for the noise
I pushed the darwin fix in b60acf2

@marsam marsam closed this Jan 6, 2021
@marsam marsam deleted the update-mp4v2 branch January 6, 2021 04:11
@Anton-Latukha
Copy link
Contributor

This was only a 25 days ago, feels like millennia.

With all this seems would wait for the 4.1.6.

I while ago rebased this fossil to the maintained fork, but most Linux distros would not.
But again - this is a half-alive fork of a fossil package.

If most distros do not use the fork - we updating would probably hit a difference and would have a wall with compiling the dependent packages.

If bot would not update it - I check lesser packages I have like 2 times a year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants