Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keeweb: 1.16.0 → 1.16.5 #106817

Merged
merged 1 commit into from Dec 31, 2020
Merged

keeweb: 1.16.0 → 1.16.5 #106817

merged 1 commit into from Dec 31, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Dec 13, 2020

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir sikmir changed the title keeweb: 1.16.0 → 1.16.3 keeweb: 1.16.0 → 1.16.4 Dec 17, 2020
@sikmir sikmir changed the title keeweb: 1.16.0 → 1.16.4 keeweb: 1.16.0 → 1.16.5 Dec 20, 2020
@WolfangAukang
Copy link
Contributor

WolfangAukang commented Dec 31, 2020 •
edited

Result of nixpkgs-review pr 106817 run on x86_64-linux 1

1 package built:
  • keeweb

Working fine and code LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/316

@AndersonTorres AndersonTorres merged commit 6b99abd into NixOS:master Dec 31, 2020
@sikmir sikmir deleted the keeweb branch December 31, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WolfangAukang WolfangAukang WolfangAukang approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sikmir @WolfangAukang @nixos-discourse @AndersonTorres