Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-geiger: 0.9.1 -> 0.10.2 #106258

Merged
merged 1 commit into from Dec 7, 2020
Merged

cargo-geiger: 0.9.1 -> 0.10.2 #106258

merged 1 commit into from Dec 7, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Dec 7, 2020

Motivation for this change

Bump cargo-geiger from 0.9.1 to 0.10.2
Closes #106142

Things done

  • Remove cargo-lock.patch

    • Upstream crate now compiles fine without patch

  • Use cargo-insta for testing

    • Using cargo-insta for testing, we can now run the test suite without
      skipping any tests
Excerpt of output for cargo-geiger-0.10.2 build 
cargo-geiger>    Compiling cargo-geiger v0.10.2 (/build/source/cargo-geiger)
cargo-geiger>     Finished test [unoptimized + debuginfo] target(s) in 51.15s
cargo-geiger>      Running target/debug/deps/cargo_geiger-6e7cda00618c9c3a
cargo-geiger> running 0 tests
cargo-geiger> test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
cargo-geiger>      Running target/debug/deps/mod-a96760f21b696cb8
cargo-geiger> running 7 tests
cargo-geiger> .......
cargo-geiger> test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
cargo-geiger>      Running target/debug/deps/geiger-1fa18bfc535415eb
cargo-geiger> running 0 tests
cargo-geiger> test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
cargo-geiger>    Doc-tests geiger
cargo-geiger> running 0 tests
cargo-geiger> test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
cargo-geiger> info: 6 snapshots to review
cargo-geiger> use `cargo insta review` to review snapshots
cargo-geiger> installing
cargo-geiger> post-installation fixup
cargo-geiger> shrinking RPATHs of ELF executables and libraries in /nix/store/crq68p0a97pa96dfnzalccz53smh59al-cargo-geiger-0.10.2
cargo-geiger> shrinking /nix/store/crq68p0a97pa96dfnzalccz53smh59al-cargo-geiger-0.10.2/bin/cargo-geiger
cargo-geiger> strip is /nix/store/cqxfi2q7d7k6y0q91wcx2cbkj4xsak63-binutils-2.31.1/bin/strip
cargo-geiger> stripping (with command strip and flags -S) in /nix/store/crq68p0a97pa96dfnzalccz53smh59al-cargo-geiger-0.10.2/bin
cargo-geiger> patching script interpreter paths in /nix/store/crq68p0a97pa96dfnzalccz53smh59al-cargo-geiger-0.10.2
cargo-geiger> checking for references to /build/ in /nix/store/crq68p0a97pa96dfnzalccz53smh59al-cargo-geiger-0.10.2...

cc @marsam @8573

@evanjs
cargo-geiger: 0.9.1 -> 0.10.2
8949b18 
* Remove cargo-lock.patch
  * Upstream crate now compiles fine without patch

* Use cargo-insta for testing
  * Using cargo-insta for testing, we can now run the test suite without
    skipping any tests
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106258 run on x86_64-linux 1

1 package built:
  • cargo-geiger

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106258 run on x86_64-darwin 1

1 package built:
  • cargo-geiger

@SuperSandro2000 SuperSandro2000 merged commit b79a6e1 into NixOS:master Dec 7, 2020
@evanjs evanjs deleted the cargo-geiger/0.10.2 branch December 7, 2020 17:57
@8573
Copy link
Contributor

8573 commented Dec 7, 2020

That was quick! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo-geiger fails check phase
3 participants
@evanjs @SuperSandro2000 @8573