Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unix chkpwd wrapper #106263

Closed
wants to merge 4 commits into from
Closed

Use unix chkpwd wrapper #106263

wants to merge 4 commits into from

Conversation

jcumming
Copy link
Contributor

@jcumming jcumming commented Dec 7, 2020

Motivation for this change

Non-root applications that use PAM to check auth credentials need a suid helper application to access /etc/shadow.

NixOS creates this wrapper at /run/wrappers/chkpwd, this patch the pam_unix security module to use the suid wrapper. It provides a function argument to allow overriding the chkpwd to use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 7, 2020 •
edited

@jcumming please target staging with the mass rebuild. Also do not merge master into a PR to fix a merge conflict and also squash the commits together.

@jcumming
Copy link
Contributor Author

jcumming commented Dec 7, 2020

Created PR in #106285, closing this one.

@jcumming jcumming closed this Dec 7, 2020
@SuperSandro2000
Copy link
Member

Please do not create not necessary PRs if you can reuse an existing one by a simple force push.

@jcumming
Copy link
Contributor Author

jcumming commented Dec 8, 2020

Please do not create not necessary PRs if you can reuse an existing one by a simple force push.

Reviewing PRs is a thankless job, and I understand rigour is required to ensure high quality of the codebase.

I appreciate you being polite, but you aren't being helpful. Can you throw a couple links down on how to:

  • force push a PR
  • retarget a PR to a different branch

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcumming @SuperSandro2000