Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openrgb: 0.4 -> 0.5 #106264

Merged
merged 3 commits into from Dec 7, 2020
Merged

openrgb: 0.4 -> 0.5 #106264

merged 3 commits into from Dec 7, 2020

Conversation

Technical27
Copy link
Contributor

@Technical27 Technical27 commented Dec 7, 2020 •
edited

Motivation for this change

0.5 was just released

Things done
  • fetch from GitLab (project was moved there)
  • added udev rules
  • remove installCheck because it now always fails
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jonringer December 7, 2020 18:09
jonringer
jonringer reviewed Dec 7, 2020
View reviewed changes
pkgs/applications/misc/openrgb/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/openrgb/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/openrgb/default.nix Outdated Show resolved Hide resolved
@Technical27
openrgb: 0.4 -> 0.5
3766912
@Technical27
openrgb: add udev rules
437fd4b 
The udev rules give user access to supported devices.
@Technical27
openrgb: update installCheck
ec9bdbc 
Use $TMPDIR for the home directory to prevent openrgb from aborting.
@ofborg ofborg bot requested a review from jonringer December 7, 2020 19:07
jonringer
jonringer approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 106264 1

1 package built:
  • openrgb

@jonringer jonringer merged commit 68d1006 into NixOS:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Technical27 @jonringer