Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f7e50d948f37
Choose a base ref
...
head repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 314a93287511
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Dec 7, 2020

  1. Fix FFTFilter.cpp crash issue with MSYS2 mingw64 Release build

    Compute next highest power of 2 to fix issues when using code:
    const size_t npoints = pow(2, ceil(log2(npoints_raw)));
    The original code (pow(2, ceil(log2())) has some border effects when built with MSYS2 mingw64 "Release" mode as it does not compute correctly the highest power of 2 for example with parameter 100000 it was returning 131071 (instead of 131072) which crashed ffts.
    This implementation fix issue ngscopeclient/scopehal-apps#295
    bvernoux authored Dec 7, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    bd2c7b5 View commit details
  2. Merge pull request #377 from bvernoux/patch-5

    Fix FFTFilter.cpp crash issue with MSYS2 mingw64 Release build
    azonenberg authored Dec 7, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    314a932 View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 scopeprotocols/FFTFilter.cpp
2 changes: 1 addition & 1 deletion scopeprotocols/FFTFilter.cpp
Original file line number Diff line number Diff line change
@@ -176,7 +176,7 @@ void FFTFilter::Refresh()

//Round size up to next power of two
const size_t npoints_raw = din->m_samples.size();
const size_t npoints = pow(2, ceil(log2(npoints_raw)));
const size_t npoints = next_pow2(npoints_raw);
LogTrace("FFTFilter: processing %zu raw points\n", npoints_raw);
LogTrace("Rounded to %zu\n", npoints);