Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid 90 degree turns does not work #8364

Closed
TinCanTech opened this issue Dec 7, 2020 · 14 comments
Closed

Forbid 90 degree turns does not work #8364

TinCanTech opened this issue Dec 7, 2020 · 14 comments

Comments

@TinCanTech
Copy link

Version of OpenTTD

1.10.3

Expected result

No 90 degree turns allowed

Actual result

90 degree turns are allowed

Steps to reproduce

Force a 90 degree turn

See:
MAG-01, 6th Jul 3541#1

@auge8472
Copy link
Contributor

auge8472 commented Dec 7, 2020

That's not a 90-degree-turn but the shortest and sharpest possible construction of a two-times-45-degree-turn.

@JGRennison
Copy link
Contributor

This setting can be overridden on a per-railtype basis by NewGRFs,
It would probably be useful if you could include a savegame which shows the issue.

@James103
Copy link
Contributor

James103 commented Dec 7, 2020

@TinCanTech At the very least, what NewGRFs do you have in your savegame?

@TinCanTech
Copy link
Author

That's not a 90-degree-turn but the shortest and sharpest possible construction of a two-times-45-degree-turn.

I presume you mean something like this:
MAG-01, 25th Feb 3544x
90 degree turns are banned - 2x 45 degree bends are not ?

@TinCanTech
Copy link
Author

what NewGRFs do you have in your savegame?

#openttdcoop NewGRF package 0.8
OpenGFX+ Landscape 1.1.2

@TinCanTech
Copy link
Author

Save game - Enjoy ;-)

MAG-01, 11th Jan 3544.sav.zip

@glx22
Copy link
Contributor

glx22 commented Dec 7, 2020

Is the train lost ?

@TinCanTech
Copy link
Author

Is the train lost ?

Something like that, I was having congestion problems ..

@glx22
Copy link
Contributor

glx22 commented Dec 7, 2020

Forbid 90° is used when pathfinding but lost train can't find path so they don't follow the rule.

@TinCanTech
Copy link
Author

OK - That explains it, thanks!

@JGRennison
Copy link
Contributor

Forbid 90° is used when pathfinding but lost train can't find path so they don't follow the rule.

This is not consistent with the code or what the setting is supposed to do. 90° detection is done outside the pathfinder as well, in track following, end of line detection, PBS reservation follow/extension, safe waiting position detection, etc. (Take a look at the call sites of Rail90DegTurnDisallowed).
The only time a train should be able to do this is if the setting is switched after the leading vehicle has already passed over the 90° turn.

@TinCanTech
Copy link
Author

For the record, I always have "Forbid trains from making 90 degree turns: On"

@TinCanTech TinCanTech reopened this Dec 7, 2020
@auge8472
Copy link
Contributor

auge8472 commented Dec 8, 2020

At zerost: Sorry for being so very short in my first comment. Writing on the phone is a pain. May the technical progress big as a whole planet, my fingers does and will not shrink to match the char-key-buttons in any way.

That's not a 90-degree-turn but the shortest and sharpest possible construction of a two-times-45-degree-turn.

At first: I was wrong with interpreting your screenshot in the opening message. I payed attention to the two sharp two-times-45-degree-curves but not to the turning train. Sorry.

I presume you mean something like this:
MAG-01, 25th Feb 3544x
90 degree turns are banned - 2x 45 degree bends are not ?

At second: Sharp curves with two times 45°-turns are not affected by the setting.

examples of 90-degree turns compared to two-times-45-degree-turns

Because the discussion shows that the issue seems to be independent from that take my notice only as a notice.

@TinCanTech
Copy link
Author

TinCanTech commented Dec 23, 2020

At first: I was wrong with interpreting your screenshot in the opening message. I payed attention to the two sharp two-times-45-degree-curves but not to the turning train. Sorry.

No problem, I should have made my 'shot more clear ;-)

the discussion shows that the issue seems to be independent from that

Agreed.

For the time being, we must accept:
There is more to detecting a 90 degree bend than to banning them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants