Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with newer AWS SDKs #4316

Merged
merged 1 commit into from Dec 5, 2020
Merged

Fix compatibility with newer AWS SDKs #4316

merged 1 commit into from Dec 5, 2020

Conversation

stephank
Copy link
Contributor

@stephank stephank commented Dec 4, 2020 •
edited

Fixes #3201.

The incompatibility appears to have been introduced in AWS SDK 1.7.115 through: aws/aws-sdk-cpp@4d92ec7

I ran tests locally on macOS against AWS SDK 1.8.99 with the following overlay:

--- a/flake.nix
+++ b/flake.nix
@@ -223,6 +223,20 @@
             '';
         };
 
+        aws-sdk-cpp = prev.aws-sdk-cpp.overrideAttrs (oldAttrs: rec {
+          version = "1.8.99";
+          src = final.fetchFromGitHub {
+            owner = "awslabs";
+            repo = "aws-sdk-cpp";
+            rev = version;
+            hash = "sha256-CqiVCA8Ugc4TnXuatLfh2D8qrFaYod40W1gmWJyqlns=";
+          };
+          patches = [ ];
+          cmakeFlags = oldAttrs.cmakeFlags ++ [
+            "-DENABLE_TESTING=OFF" # Relies on network
+          ];
+        });
+
       };
 
       hydraJobs = {

@stephank
Fix compatibility with newer AWS SDKs
e20a3ec 
Tested against AWS SDK 1.8.99. Fixes NixOS#3201.
@edolstra edolstra merged commit a5d85d0 into NixOS:master Dec 5, 2020
@stephank stephank deleted the aws-sdk-compat branch December 5, 2020 12:31
orivej pushed a commit to orivej/nix that referenced this pull request Dec 26, 2020
@stephank @orivej
Fix compatibility with newer AWS SDKs (NixOS#4316)
024c0ea 
Tested against AWS SDK 1.8.99. Fixes NixOS#3201.

(cherry picked from commit e20a3ec)
edolstra added a commit that referenced this pull request Dec 28, 2020
@edolstra
Merge pull request #4404 from orivej/2.3-aws-sdk-cpp
3a6a2f8 
Backport compatibility with newer AWS SDKs to 2.3 (#4316)
orivej added a commit to orivej/nixpkgs that referenced this pull request Jan 6, 2021
@orivej
nixUnstable: 2.4pre20201201_5a6ddb3 -> 2.4pre20201205_a5d85d0
4e2a4fc 
It support newer aws-cpp-sdk since NixOS/nix#4316
@ldesgoui ldesgoui mentioned this pull request Aug 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nix is not compatible with aws-sdk-cpp 1.7.217
2 participants
@stephank @edolstra