Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pam_mount: 2.16 -> 2.17 #105901

Merged
merged 1 commit into from Mar 19, 2021
Merged

pam_mount: 2.16 -> 2.17 #105901

merged 1 commit into from Mar 19, 2021

Conversation

dnr
Copy link
Contributor

@dnr dnr commented Dec 4, 2020

Motivation for this change

This includes a fix for LUKS2 that was previously applied in nixpkgs as a patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested on my system (which uses pam_mount for my home directory) by rebasing on nixos-20.09, rebuilding, and rebooting.

@dnr
Copy link
Contributor Author

dnr commented Dec 4, 2020

@peterhoeg It looks like upstream finally released this, so we can drop the patch.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105901 run on x86_64-linux 1

1 package built:
  • pam_mount

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 105901 run on x86_64-linux 1

1 package built:
  • pam_mount

@jonringer jonringer merged commit 7244e1c into NixOS:master Mar 19, 2021
@dnr dnr deleted the update-pam-mount branch June 19, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants