Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: Prefix $PATH with xdg_utils #105894

Merged
merged 1 commit into from Dec 11, 2020
Merged

firefox: Prefix $PATH with xdg_utils #105894

merged 1 commit into from Dec 11, 2020

Conversation

ryneeverett
Copy link
Contributor

Motivation for this change

Resolve #92751.

Comparable to #96922.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Dec 4, 2020 •
edited

Firefox is currently your default browser

❤️

Edit: testing this messed up my browser profile … wow. 😢

@ryneeverett
Copy link
Contributor Author

Edit: testing this messed up my browser profile … wow.

Yikes. I'm guessing this is the result of another firefox patch that landed in master yesterday.

@ryneeverett
Copy link
Contributor Author

#91724

@mweinelt
Copy link
Member

mweinelt commented Dec 4, 2020 via email

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 5, 2020
@mweinelt
Copy link
Member

mweinelt commented Dec 5, 2020

Can you please add a motivation to your commit message, so that we don't need to rely on GitHub history to follow the intent of your commit.

@ryneeverett
firefox: Prefix $PATH with xdg_utils
36436ee 
This is required for certain URIs that require launching external
programs (e.g. mailto:, magnet:, or irc:) or setting the default browser
via xdg-settings.

Resolve NixOS#92751.

Comparable to NixOS#96922.
@symphorien
Copy link
Member

@GrahamcOfBorg firefox

@symphorien
Copy link
Member

ah oops
@GrahamcOfBorg build firefox

@mweinelt
Copy link
Member

I've run with this for close to a week. Thanks!

@mweinelt mweinelt merged commit 6a163d2 into NixOS:master Dec 11, 2020
@erictapen
Copy link
Member

Backported this in 1b5f650.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting browsers (Firefox, Chromium) as default have no effect in Sway.
4 participants
@ryneeverett @mweinelt @symphorien @erictapen