Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snowmachine: init at 1.0.1 #105895

Merged
merged 3 commits into from Jan 20, 2021
Merged

snowmachine: init at 1.0.1 #105895

merged 3 commits into from Jan 20, 2021

Conversation

djanatyn
Copy link
Contributor

@djanatyn djanatyn commented Dec 4, 2020

Motivation for this change

Getting into the winter spirit with some snowflakes!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

When looking for the license, I saw that it was created as BSD, but it didn't mention which BSD license:

$ rg 'BSD' -C 2 setup.py
21-    description=("A python script that will make your terminal "
22-                 "snow"),
23:    license = "BSD",
24-    setup_requires=['setuptools-git'],
25-    install_requires=requires,
--
34-        "Environment :: Console",
35-        "Environment :: Console :: Curses",
36:        "License :: OSI Approved :: BSD License",
37-    ],
38-    entry_points = {

I marked this as unfree. I'm opening an issue to ask the author to describe which BSD license to use.

@djanatyn
Copy link
Contributor Author

djanatyn commented Dec 4, 2020

I opened an issue for the licensing upstream: sontek/snowmachine#11

@SuperSandro2000 SuperSandro2000 added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Dec 5, 2020
@sontek
Copy link
Contributor

sontek commented Dec 5, 2020 •
edited

👍 I added the LICENSE and the project is tested / works on MacOS as well if that matters (also works on windows). I'm not a license expert by any means, if there is a LICENSE you prefer thats better let me know. It was my understanding that BSD was the nicest/easiest to work with so I marked that as the one

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105895 1

1 package built:
  • snowmachine

@djanatyn
Copy link
Contributor Author

djanatyn commented Dec 5, 2020 •
edited

+1 I added the LICENSE and the project is tested / works on MacOS as well if that matters (also works on windows). I'm not a license expert by any means, if there is a LICENSE you prefer thats better let me know. It was my understanding that BSD was the nicest/easiest to work with so I marked that as the one

That's great! License is definitely your choice.

The only issue I had was understanding which version of the BSD license. Thank you for clarifying and closing sontek/snowmachine#11 😄

I just pushed ac13939af3e159a2b5836fd33dd7231d4572602f2 to update the license to bsd3:

diff --git a/pkgs/applications/snowmachine/default.nix b/pkgs/applications/snowmachine/default.nix
index 878d1f494f3..d34f46d7d0d 100644
--- a/pkgs/applications/snowmachine/default.nix
+++ b/pkgs/applications/snowmachine/default.nix
@@ -15,7 +15,7 @@ buildPythonPackage rec {
   meta = with lib; {
     description = "A python script that will make your terminal snow";
     homepage = "http://github.com/sontek/snowmachine";
-    license = with licenses; [ unfree ];
+    license = with licenses; [ bsd3 ];
     maintainers = with maintainers; [ djanatyn ];
   };
 }

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105895 run on x86_64-linux 1

1 package built:
  • snowmachine

@djanatyn @SuperSandro2000
snowmachine: add pythonImportsCheck
ae0e0d2 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@djanatyn @SuperSandro2000
snowmachine: fix importCheck
6a3c777 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 105895 run on x86_64-linux 1

1 package built:
  • snowmachine

@SuperSandro2000 SuperSandro2000 merged commit 287af3b into NixOS:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
2.status: wait-for-upstream Waiting for upstream fix (or their other action). 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djanatyn @sontek @SuperSandro2000