Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.acme: Disable tests #105890

Merged
merged 1 commit into from Dec 23, 2020
Merged

pythonPackages.acme: Disable tests #105890

merged 1 commit into from Dec 23, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
python38Packages.acme.log
160:Ran 0 tests in 0.000s

python37Packages.acme.log
160:Ran 0 tests in 0.000s

python39Packages.acme.log
160:Ran 0 tests in 0.000s
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from domenkozar December 4, 2020 15:25
@jonringer
Copy link
Contributor

do you mind adding a pythonImportsCheck?

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 105890 run on x86_64-darwin 1

15 packages failed to build:
  • certbot (python38Packages.certbot)
  • python37Packages.certbot
  • python37Packages.certbot-dns-cloudflare
  • python37Packages.certbot-dns-rfc2136
  • python37Packages.certbot-dns-route53
  • python37Packages.hass-nabucasa
  • python38Packages.certbot-dns-cloudflare
  • python38Packages.certbot-dns-rfc2136
  • python38Packages.certbot-dns-route53
  • python38Packages.hass-nabucasa
  • python39Packages.certbot
  • python39Packages.certbot-dns-cloudflare
  • python39Packages.certbot-dns-rfc2136
  • python39Packages.certbot-dns-route53
  • python39Packages.hass-nabucasa
3 packages built:
  • python37Packages.acme
  • python38Packages.acme
  • python39Packages.acme

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 105890 run on x86_64-linux 1

4 packages failed to build:
  • home-assistant
  • python37Packages.hass-nabucasa
  • python38Packages.hass-nabucasa
  • python39Packages.hass-nabucasa
17 packages built:
  • certbot (python38Packages.certbot)
  • certbot-full
  • python37Packages.acme
  • python37Packages.certbot
  • python37Packages.certbot-dns-cloudflare
  • python37Packages.certbot-dns-rfc2136
  • python37Packages.certbot-dns-route53
  • python38Packages.acme
  • python38Packages.certbot-dns-cloudflare
  • python38Packages.certbot-dns-rfc2136
  • python38Packages.certbot-dns-route53
  • python39Packages.acme
  • python39Packages.certbot
  • python39Packages.certbot-dns-cloudflare
  • python39Packages.certbot-dns-rfc2136
  • python39Packages.certbot-dns-route53
  • simp_le

@SuperSandro2000 SuperSandro2000 merged commit 0afb80a into NixOS:master Dec 23, 2020
@SuperSandro2000 SuperSandro2000 deleted the acme-tests branch December 23, 2020 19:37
@SuperSandro2000
Copy link
Member Author

Build failures are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @jonringer