Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change indexes for FilterParameter from ASCII strings to numeric IDs #363

Open
azonenberg opened this issue Dec 4, 2020 · 1 comment
Open

Change indexes for FilterParameter from ASCII strings to numeric IDs #363

azonenberg opened this issue Dec 4, 2020 · 1 comment
Labels
api API improvements cleanup Removing cruft
Milestone
v0.2

Comments

@azonenberg
Copy link
Collaborator

Having integer IDs starting at 0 would allow sorting parameters independently of lexical ordering, and also be much more i18n friendly.
@azonenberg azonenberg added api API improvements cleanup Removing cruft labels Dec 4, 2020
@tarunik
Copy link
Collaborator

tarunik commented Dec 4, 2020 •
edited

Sidenote: gtkmm's translation API is a wrapper around gettext() which uses the English string directly as a key, so I'm not sure how much this'd actually gain us re: i18n. Your point about parameter sorting is fair, though, although perhaps we could look at something more sophisticated yet if we wanted to encode grouping information?

@azonenberg azonenberg added this to the v0.2 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api API improvements cleanup Removing cruft
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
2 participants
@azonenberg @tarunik